Print account address in state transition test failures #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #621 +/- ##
==========================================
- Coverage 97.30% 97.29% -0.02%
==========================================
Files 79 79
Lines 7679 7680 +1
==========================================
Hits 7472 7472
- Misses 207 208 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
chfast
approved these changes
Apr 24, 2023
rodiazet
reviewed
Apr 24, 2023
| } | ||
| if (expected_acc.balance.has_value()) | ||
| { | ||
| EXPECT_EQ(acc->balance, *expected_acc.balance) | ||
| << to_string(acc->balance) << " vs " << to_string(*expected_acc.balance); | ||
| << to_string(acc->balance) << " vs " << to_string(*expected_acc.balance) | ||
| << " account " << addr; |
There was a problem hiding this comment.
Is it possible to ass unit test here? I think I was adding in a different PR
There was a problem hiding this comment.
I doubt so, as this is a fixture code... other lines here are also not tested, they are just "covered" because they are being run during (succeeding) tests in unit test sute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.