Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change RJUMPV immediate argument to max_index #640

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Change RJUMPV immediate argument to max_index #640

merged 2 commits into from
Aug 3, 2023

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented May 8, 2023

@gumb0 gumb0 added the EOF label May 8, 2023
@gumb0 gumb0 changed the title Change RJUMPV immediate argument to mean max_index Change RJUMPV immediate argument to max_index May 9, 2023
@gumb0 gumb0 marked this pull request as ready for review May 9, 2023 11:02
chfast
chfast requested changes May 11, 2023
View reviewed changes
lib/evmone/eof.cpp Outdated Show resolved Hide resolved
@gumb0 gumb0 changed the base branch from master to change-data-section-kind July 19, 2023 18:55
@gumb0 gumb0 changed the base branch from change-data-section-kind to master July 19, 2023 18:55
@gumb0 gumb0 changed the base branch from master to change-data-section-kind July 20, 2023 08:30
@gumb0 gumb0 force-pushed the change-data-section-kind branch 2 times, most recently from 7f89c95 to 6b35712 Compare August 1, 2023 10:57
@codecov
Copy link

codecov bot commented Aug 3, 2023 •
edited
Loading

Codecov Report

Merging #640 (916e60f) into master (5b9c216) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #640      +/-   ##
==========================================
+ Coverage   97.45%   97.48%   +0.02%     
==========================================
  Files          85       85              
  Lines        8184     8177       -7     
==========================================
- Hits         7976     7971       -5     
+ Misses        208      206       -2
Flag Coverage Δ
blockchaintests 62.71% <0.00%> (+0.09%) ⬆️
statetests 74.16% <100.00%> (+0.02%) ⬆️
statetests-silkpre 23.19% <0.00%> (+0.01%) ⬆️
unittests 95.00% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
lib/evmone/eof.hpp 100.00% <ø> (ø)
lib/evmone/eof.cpp 83.68% <100.00%> (+0.35%) ⬆️
lib/evmone/instructions.hpp 100.00% <100.00%> (ø)
test/unittests/eof_validation_test.cpp 100.00% <100.00%> (ø)
test/utils/bytecode.hpp 95.85% <100.00%> (+0.01%) ⬆️

@gumb0 gumb0 force-pushed the change-data-section-kind branch from 6b35712 to 3e1a847 Compare August 3, 2023 10:01
Base automatically changed from change-data-section-kind to master August 3, 2023 10:11
@gumb0 gumb0 merged commit 095f83a into master Aug 3, 2023
@gumb0 gumb0 deleted the new-rjumpv branch August 3, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chfast chfast chfast approved these changes

Assignees
No one assigned
Labels
EOF
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gumb0 @chfast