Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockchain tests support: Withdrawals hashing #690

Merged
merged 3 commits into from
Aug 23, 2023
Merged

Conversation

rodiazet
Copy link
Collaborator

@rodiazet rodiazet commented Aug 22, 2023

  • Support withdrawals root hash calculation
  • Add ArrowGlacier fork name mapping to evmc_revision (cast to London fork).

@rodiazet rodiazet force-pushed the withdrawals-hashing branch from 954683f to b92abd9 Compare August 22, 2023 09:01
@rodiazet rodiazet requested a review from chfast August 22, 2023 09:01
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #690 (1ffe20f) into master (f5ca539) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #690      +/-   ##
==========================================
+ Coverage   97.53%   97.55%   +0.01%     
==========================================
  Files          86       88       +2     
  Lines        8249     8287      +38     
==========================================
+ Hits         8046     8084      +38     
  Misses        203      203              
Flag Coverage Δ
blockchaintests 63.19% <ø> (ø)
statetests 74.18% <7.69%> (-0.03%) ⬇️
statetests-silkpre 23.10% <2.17%> (-0.10%) ⬇️
unittests 95.32% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
test/state/state.hpp 100.00% <ø> (ø)
test/statetest/statetest.hpp 100.00% <ø> (ø)
test/state/mpt_hash.cpp 100.00% <100.00%> (ø)
test/state/mpt_hash.hpp 100.00% <100.00%> (ø)
test/state/state.cpp 98.00% <100.00%> (+0.04%) ⬆️
test/statetest/statetest_loader.cpp 90.41% <100.00%> (+0.08%) ⬆️
test/unittests/state_mpt_hash_test.cpp 99.19% <100.00%> (+0.14%) ⬆️
test/unittests/state_transition_block_test.cpp 100.00% <100.00%> (ø)
test/unittests/statetest_withdrawals_test.cpp 100.00% <100.00%> (ø)

@chfast chfast force-pushed the withdrawals-hashing branch from 904987d to 3682efe Compare August 23, 2023 08:36
@@ -10,6 +10,7 @@
#include <test/state/mpt_hash.hpp>
#include <test/state/rlp.hpp>
#include <test/state/state.hpp>
#include <test/statetest/statetest.hpp>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not mix JSON with these tests.

@rodiazet rodiazet force-pushed the withdrawals-hashing branch from 3682efe to 6453cd7 Compare August 23, 2023 09:18
@rodiazet rodiazet force-pushed the withdrawals-hashing branch from 6453cd7 to 1ffe20f Compare August 23, 2023 09:19
@rodiazet rodiazet merged commit c9afe1f into master Aug 23, 2023
@rodiazet rodiazet deleted the withdrawals-hashing branch August 23, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants