Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

state: Delete empty accounts after each tx #701

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Conversation

rodiazet
Copy link
Collaborator

@rodiazet rodiazet commented Sep 4, 2023

Delete empty accounts after each transaction
and after applying withdrawals and block rewards.

@rodiazet rodiazet requested a review from chfast September 4, 2023 14:20
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #701 (2befbb1) into master (6ce4e70) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #701   +/-   ##
=======================================
  Coverage   97.60%   97.60%           
=======================================
  Files          95       95           
  Lines        8644     8648    +4     
=======================================
+ Hits         8437     8441    +4     
  Misses        207      207           
Flag Coverage Δ
blockchaintests 62.37% <ø> (ø)
statetests 73.49% <100.00%> (+0.05%) ⬆️
statetests-silkpre 22.67% <100.00%> (+0.05%) ⬆️
unittests 95.58% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
test/state/state.cpp 98.77% <100.00%> (+0.03%) ⬆️

test/state/state.cpp Outdated Show resolved Hide resolved
test/state/state.cpp Outdated Show resolved Hide resolved
test/state/state.cpp Outdated Show resolved Hide resolved
Delete empty accounts after each transaction
and after applying withdrawals and block rewards.

Co-authored-by: Paweł Bylica <pawel@ethereum.org>
@chfast chfast force-pushed the clear-empty-accounts branch from d2d6670 to 2befbb1 Compare September 26, 2023 17:10
@chfast chfast changed the title Clear empty accounts after each tx and in the end of block processing state: Delete empty accounts after each tx Sep 26, 2023
@chfast chfast merged commit 65d4b10 into master Sep 26, 2023
3 checks passed
@chfast chfast deleted the clear-empty-accounts branch September 26, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants