Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement BLOBBASEFEE instruction from EIP-7516 #708

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Conversation

chfast
Copy link
Member

@chfast chfast commented Sep 23, 2023

Implement BLOBBASEFEE instruction from EIP-7516: "BLOBBASEFEE opcode".

@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Merging #708 (d526559) into master (e40b952) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #708   +/-   ##
=======================================
  Coverage   97.69%   97.70%           
=======================================
  Files         101      102    +1     
  Lines        9381     9404   +23     
=======================================
+ Hits         9165     9188   +23     
  Misses        216      216           
Flag Coverage Δ
blockchaintests 62.23% <0.00%> (-0.15%) ⬇️
statetests 64.98% <0.00%> (-0.08%) ⬇️
statetests-silkpre 26.09% <13.04%> (-0.04%) ⬇️
unittests 95.70% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
lib/evmone/instructions.hpp 100.00% <100.00%> (ø)
test/unittests/evm_eip7516_blobbasefee_test.cpp 100.00% <100.00%> (ø)
test/unittests/instructions_test.cpp 89.58% <ø> (ø)

@chfast chfast added the Cancun Changes for Cancun Ethereum spec revision label Sep 24, 2023
@@ -510,6 +510,11 @@ inline void blobhash(StackTop stack, ExecutionState& state) noexcept
0;
}

inline void blobbasefee(StackTop stack, ExecutionState& state) noexcept
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are some discussions renaming this. Should we wait for that or merge?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is likely the name we will end up with.

@chfast chfast merged commit 781875d into master Oct 26, 2023
3 checks passed
@chfast chfast deleted the blobbasefee branch October 26, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cancun Changes for Cancun Ethereum spec revision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants