Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move trace output earlier in state transition tests #714

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented Sep 27, 2023

When I debug state transition tests, sometimes I want to see the trace even if this assertion fails

ASSERT_NE(acc, nullptr) << "account " << addr << " should exist";

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #714 (604fe80) into master (74d2143) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #714   +/-   ##
=======================================
  Coverage   97.60%   97.60%           
=======================================
  Files          95       95           
  Lines        8645     8645           
=======================================
  Hits         8438     8438           
  Misses        207      207           
Flag Coverage Δ
blockchaintests 62.37% <ø> (ø)
statetests 73.47% <ø> (ø)
statetests-silkpre 22.64% <0.00%> (ø)
unittests 95.58% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
test/unittests/state_transition.cpp 94.91% <100.00%> (ø)

@gumb0 gumb0 requested review from axic, chfast and rodiazet September 27, 2023 15:46
@chfast chfast merged commit 78ad5fe into master Sep 28, 2023
3 checks passed
@chfast chfast deleted the output-trace-earlier branch September 28, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants