Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate and reject code/gas-observability in EOF #834

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Conversation

pdobacz
Copy link
Collaborator

@pdobacz pdobacz commented Mar 14, 2024

OP_CODESIZE, OP_CODECOPY, OP_EXTCODESIZE, OP_EXTCODECOPY, OP_EXTCODEHASH, OP_GAS should be rejected by EOF Megaspec (and by EIP-3540 after updates), so here it is.

Let me know if I missed something here, otherwise I'll fix the tests to account for this.

tests would be set to a tag on this branch: ethereum/tests#1355

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.11%. Comparing base (ccc92f1) to head (8d97dec).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #834      +/-   ##
==========================================
- Coverage   98.12%   98.11%   -0.02%     
==========================================
  Files         118      118              
  Lines       11843    11776      -67     
==========================================
- Hits        11621    11554      -67     
  Misses        222      222              
Flag Coverage Δ
blockchaintests 61.56% <ø> (ø)
statetests 61.93% <ø> (ø)
statetests-silkpre 23.41% <0.00%> (+0.08%) ⬆️
unittests 96.64% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
lib/evmone/baseline_instruction_table.cpp 100.00% <ø> (ø)
test/unittests/eof_validation_test.cpp 100.00% <100.00%> (ø)
test/unittests/evm_eof_test.cpp 100.00% <ø> (ø)

@pdobacz pdobacz marked this pull request as ready for review March 14, 2024 12:49
@pdobacz pdobacz requested a review from gumb0 March 14, 2024 12:50
@pdobacz pdobacz self-assigned this Mar 14, 2024
@pdobacz pdobacz force-pushed the deprecate-eof-ops branch from e5a2f96 to 477b766 Compare March 18, 2024 11:12
@pdobacz pdobacz force-pushed the deprecate-eof-ops branch from 477b766 to 8d97dec Compare March 18, 2024 11:15
@pdobacz pdobacz merged commit 0abe773 into master Mar 18, 2024
25 checks passed
@pdobacz pdobacz deleted the deprecate-eof-ops branch March 18, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants