Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EOF validation tests runner: support initcode flag #936

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented Jun 26, 2024

This is the fixture format agreed on EOF implementers call and produced by EEST in ethereum/execution-spec-tests#651

Based on #916 because it removes the tests for initcode_runtime container kind, and those were failing the run of exported validation tests.

@gumb0 gumb0 added the EOF label Jun 26, 2024
@gumb0 gumb0 force-pushed the test/eoftest-initcode branch from c0521fa to 650b512 Compare June 26, 2024 10:32
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.23%. Comparing base (f3222be) to head (9340a9c).

Current head 9340a9c differs from pull request most recent head aa63844

Please upload reports for the commit aa63844 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #936       +/-   ##
===========================================
+ Coverage   22.84%   94.23%   +71.39%     
===========================================
  Files         139      142        +3     
  Lines       16078    16120       +42     
===========================================
+ Hits         3673    15191    +11518     
+ Misses      12405      929    -11476     
Flag Coverage Δ
eof_execution_spec_tests 16.51% <25.00%> (+0.01%) ⬆️
ethereum_tests_silkpre 18.85% <0.00%> (?)
execution_spec_tests 17.98% <0.00%> (+0.01%) ⬆️
unittests 89.67% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
test/eoftest/eoftest_runner.cpp 87.50% <100.00%> (+12.50%) ⬆️
test/unittests/eof_validation.cpp 92.98% <100.00%> (+92.98%) ⬆️

... and 119 files with indirect coverage changes

@gumb0 gumb0 marked this pull request as draft June 26, 2024 10:38
@gumb0 gumb0 force-pushed the test/eoftest-initcode branch from e70c763 to 51be853 Compare June 26, 2024 16:13
@gumb0 gumb0 changed the base branch from master to unreferenced-subcontainers June 26, 2024 16:18
@gumb0 gumb0 marked this pull request as ready for review June 26, 2024 16:53
@gumb0 gumb0 requested review from pdobacz and chfast June 26, 2024 16:53
@gumb0 gumb0 self-assigned this Jun 26, 2024
@chfast chfast force-pushed the unreferenced-subcontainers branch from 3e6cf42 to df592fe Compare June 28, 2024 09:45
@chfast chfast force-pushed the test/eoftest-initcode branch from 51be853 to e1a5d6f Compare June 28, 2024 09:57
@chfast chfast added the tests Testing infrastructure label Jun 28, 2024
@chfast chfast force-pushed the test/eoftest-initcode branch from 7cd83cd to 9340a9c Compare June 28, 2024 11:01
Base automatically changed from unreferenced-subcontainers to master June 28, 2024 12:04
@chfast chfast force-pushed the test/eoftest-initcode branch from 9340a9c to aa63844 Compare June 28, 2024 12:08
@chfast chfast enabled auto-merge June 28, 2024 12:09
@chfast chfast merged commit 1835714 into master Jun 28, 2024
24 checks passed
@chfast chfast deleted the test/eoftest-initcode branch June 28, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EOF tests Testing infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants