eof: Represent MAGIC as bytes_view #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows using `.starts_with()`.
pdobacz
approved these changes
Jul 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #947 +/- ##
==========================================
- Coverage 94.29% 94.29% -0.01%
==========================================
Files 143 143
Lines 16120 16119 -1
==========================================
- Hits 15200 15199 -1
Misses 920 920
Flags with carried forward coverage won't be shown. Click here to find out more.
|
chfast
added a commit
that referenced
this pull request
Jul 23, 2024
Fixes the bug introduced in #947 where reading the version byte is missing the bounds check.
chfast
added a commit
that referenced
this pull request
Jul 24, 2024
Fixes the bug introduced in #947 where reading the version byte is missing the bounds check.
chfast
added a commit
that referenced
this pull request
Jul 24, 2024
Fixes the bug introduced in #947 where reading the version byte is missing the bounds check. This bug is hard to detect when `std::string` is used as the test container so the unit test framework has been modified to make it easier. Found by a fuzzer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows using
.starts_with().