Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor system_call() #976

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Refactor system_call() #976

merged 2 commits into from
Sep 5, 2024

Conversation

chfast
Copy link
Member

@chfast chfast commented Aug 19, 2024

Refactor and abstract the system_call() to make adding new system contracts easier.

@chfast chfast requested review from gumb0 and battlmonstr August 19, 2024 21:18
@chfast chfast changed the title Refactor system_call(). Refactor system_call() Aug 20, 2024
@chfast chfast requested a review from pdobacz August 20, 2024 08:19
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.29%. Comparing base (57ff8dd) to head (87a8918).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #976   +/-   ##
=======================================
  Coverage   94.29%   94.29%           
=======================================
  Files         143      144    +1     
  Lines       16149    16155    +6     
=======================================
+ Hits        15228    15234    +6     
  Misses        921      921           
Flag Coverage Δ
eof_execution_spec_tests 16.70% <55.55%> (+0.02%) ⬆️
ethereum_tests 26.61% <61.11%> (+0.03%) ⬆️
ethereum_tests_silkpre 18.68% <0.00%> (-0.01%) ⬇️
execution_spec_tests 17.76% <61.11%> (+0.03%) ⬆️
unittests 89.73% <97.22%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
test/blockchaintest/blockchaintest_runner.cpp 77.41% <ø> (ø)
test/state/state.cpp 90.03% <ø> (-0.45%) ⬇️
test/state/state.hpp 100.00% <ø> (ø)
test/state/system_contracts.cpp 100.00% <100.00%> (ø)
test/t8n/t8n.cpp 86.89% <ø> (ø)
test/unittests/state_system_call_test.cpp 100.00% <100.00%> (ø)

@chfast chfast force-pushed the state/system_contracts_refactor branch from 25d220b to a94a3ec Compare August 20, 2024 09:12
Copy link
Collaborator

@pdobacz pdobacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for the comment, I think it's useful, I only scanned 4788 and missed the empty account part

@@ -0,0 +1,74 @@
// evmone: Fast Ethereum Virtual Machine implementation
// Copyright 2023 The evmone Authors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Copyright 2023 The evmone Authors.
// Copyright 2024 The evmone Authors.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2023 is the year then this code was introduced.

Refactor and abstract the `system_call()` to make adding new system
contracts easier.
Make address of system contracts public.
@chfast chfast force-pushed the state/system_contracts_refactor branch from 5fc2762 to 87a8918 Compare September 5, 2024 10:33
@chfast chfast merged commit 080a341 into master Sep 5, 2024
25 checks passed
@chfast chfast deleted the state/system_contracts_refactor branch September 5, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants