Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Ensure exported state tests have all fields #993

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

pdobacz
Copy link
Collaborator

@pdobacz pdobacz commented Sep 9, 2024

I was wrong when I said that the format inconsistency had a test which we can make pass by amending the exported format - there were no exclusions which my fix would fix. So to have some testing mechanism of correctness, we can maybe add an assertion in statetest_loader like this? I don't want to overdo it and this seems safe to do.

I guess we can also leave it without the assertion.

I don't know yet about the other format inconsistencies found, so I might add more commits here

@pdobacz pdobacz requested a review from chfast September 9, 2024 15:59
@pdobacz pdobacz self-assigned this Sep 9, 2024
test/statetest/statetest_export.cpp Outdated Show resolved Hide resolved
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.84%. Comparing base (ad04d4e) to head (68da00b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #993   +/-   ##
=======================================
  Coverage   93.84%   93.84%           
=======================================
  Files         146      146           
  Lines       15456    15460    +4     
=======================================
+ Hits        14505    14509    +4     
  Misses        951      951           
Flag Coverage Δ
eof_execution_spec_tests 17.42% <20.00%> (+<0.01%) ⬆️
ethereum_tests 27.81% <20.00%> (-0.01%) ⬇️
ethereum_tests_silkpre 19.48% <20.00%> (+<0.01%) ⬆️
execution_spec_tests 18.93% <20.00%> (+<0.01%) ⬆️
unittests 89.01% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
test/statetest/statetest_export.cpp 100.00% <100.00%> (ø)
test/statetest/statetest_loader.cpp 96.83% <100.00%> (+0.01%) ⬆️
test/unittests/state_transition.cpp 97.58% <100.00%> (+0.05%) ⬆️

@pdobacz pdobacz force-pushed the fix-statetest-export branch from 3e18395 to 52e8d22 Compare September 9, 2024 16:18
@pdobacz pdobacz changed the title test: Ensure exported state tests have non-null pre test: Ensure exported state tests have all fields Sep 10, 2024
@pdobacz pdobacz force-pushed the fix-statetest-export branch from dd97a46 to 2d4d96f Compare September 10, 2024 07:31
@pdobacz
Copy link
Collaborator Author

pdobacz commented Sep 10, 2024

@chfast Hey I think I figured out that it is ok to add accessLists and currentRandom like that (see the recent commit). Both were reported missing by EELS team, PTAL

@pdobacz pdobacz requested a review from chfast September 10, 2024 07:32
Copy link
Member

@chfast chfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please update the description because it will become the git commit message.

test/unittests/state_transition.cpp Outdated Show resolved Hide resolved
test/unittests/state_transition.cpp Show resolved Hide resolved
@pdobacz pdobacz force-pushed the fix-statetest-export branch from b6c02a9 to 2acef8d Compare September 10, 2024 11:55
@pdobacz pdobacz force-pushed the fix-statetest-export branch from 2acef8d to 68da00b Compare September 11, 2024 08:15
@pdobacz pdobacz merged commit 35b7475 into master Sep 11, 2024
25 checks passed
@pdobacz pdobacz deleted the fix-statetest-export branch September 11, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants