Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

precompiles: Implement EIP-2537's bls12_g2mul #999

Merged
merged 1 commit into from
Sep 13, 2024
Merged

precompiles: Implement EIP-2537's bls12_g2mul #999

merged 1 commit into from
Sep 13, 2024

Conversation

rodiazet
Copy link
Collaborator

Implementation of the bls12_g2mul precompile: E2 affine point's multiplication from BLS12-381 curve according to the EIP-2537 spec https://eips.ethereum.org/EIPS/eip-2537#abi-for-g2-multiplication.

Depends on #995

@rodiazet rodiazet added precompiles Related to EVM precompiles Prague Changes for Prague upgrade labels Sep 11, 2024
@rodiazet rodiazet requested a review from chfast September 11, 2024 10:33
@rodiazet rodiazet changed the title precompiles: Implement EIP-2537's bls12_g1mul precompiles: Implement EIP-2537's bls12_g2mul Sep 11, 2024
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.97%. Comparing base (39aec66) to head (347c4f5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #999      +/-   ##
==========================================
+ Coverage   93.94%   93.97%   +0.03%     
==========================================
  Files         147      147              
  Lines       15553    15580      +27     
==========================================
+ Hits        14611    14642      +31     
+ Misses        942      938       -4     
Flag Coverage Δ
eof_execution_spec_tests 17.41% <0.00%> (-0.04%) ⬇️
ethereum_tests 27.59% <0.00%> (-0.05%) ⬇️
ethereum_tests_silkpre 19.32% <0.00%> (-0.04%) ⬇️
execution_spec_tests 19.31% <70.00%> (+0.10%) ⬆️
unittests 88.95% <66.66%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
lib/evmone_precompiles/bls.cpp 100.00% <100.00%> (ø)
test/state/precompiles.cpp 91.22% <100.00%> (+1.99%) ⬆️
test/unittests/precompiles_bls_test.cpp 100.00% <100.00%> (ø)

@rodiazet rodiazet force-pushed the bls-g2-add branch 3 times, most recently from cc6a4c5 to d871d23 Compare September 13, 2024 12:55
Base automatically changed from bls-g2-add to master September 13, 2024 13:15
@chfast chfast merged commit 1358b17 into master Sep 13, 2024
25 checks passed
@chfast chfast deleted the bls-g2-mul branch September 13, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prague Changes for Prague upgrade precompiles Related to EVM precompiles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants