Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CL-EL withdrawals harmonization: using units of Gwei #354

Merged
merged 2 commits into from
Jan 17, 2023
Merged

CL-EL withdrawals harmonization: using units of Gwei #354

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf51b89
whitespace
ralexstokes Jan 12, 2023
2565b50
mirror CL representation of withdrawal amounts in `Gwei`
ralexstokes Jan 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/engine/shanghai.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,10 @@ The fields are encoded as follows:
- `index`: `QUANTITY`, 64 Bits
- `validatorIndex`: `QUANTITY`, 64 Bits
- `address`: `DATA`, 20 Bytes
- `amount`: `QUANTITY`, 256 Bits
- `amount`: `QUANTITY`, 64 Bits

*Note*: the `amount` value is represented on the beacon chain as a little-endian value in units of Gwei, whereas the `amount` in this structure *MUST* be converted to a big-endian value in units of Wei.
*Note*: the `amount` value is represented on the beacon chain as a little-endian value in units of Gwei, whereas the
`amount` in this structure *MUST* be converted to a big-endian value in units of Gwei.
timbeiko marked this conversation as resolved.
Show resolved Hide resolved

### ExecutionPayloadV2

Expand Down Expand Up @@ -142,4 +143,4 @@ This method follows the same specification as [`engine_forkchoiceUpdatedV1`](./p

This method follows the same specification as [`engine_getPayloadV1`](./paris.md#engine_getpayloadv1) with the addition of the following:

1. Client software **SHOULD** use the sum of the block's priority fees or any other algorithm to determine `blockValue`.
1. Client software **SHOULD** use the sum of the block's priority fees or any other algorithm to determine `blockValue`.
ralexstokes marked this conversation as resolved.
Show resolved Hide resolved