Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: Deprecate empty accounts within framework. #300

Merged
merged 5 commits into from
Sep 18, 2023

Conversation

spencer-tb
Copy link
Collaborator

@spencer-tb spencer-tb commented Sep 18, 2023

Following the future improvement to deprecate empty accounts -> here, an assertion check has been added to detect empty accounts within the pre and post allocation within tests.

Note that an empty account is one which has zero nonce, code, balance and an empty storage:

"0xa94f5374fce5edbc8e2a8697c15331677e6ebf0b": {
                "nonce": "0x00",
                "balance": "0x00",
                "code": "0x",
                "storage": {}
            }

The beacon root tests have been updated to account for the latter (due to the inclusion of the system address), alongside a few withdrawals tests.

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Just a small change request :)

tests/cancun/eip4788_beacon_root/conftest.py Outdated Show resolved Hide resolved
Co-authored-by: Mario Vega <marioevz@gmail.com>
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marioevz marioevz merged commit e7a0603 into ethereum:main Sep 18, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants