Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add evm bytes to python converter #357

Merged
merged 5 commits into from
Jan 9, 2024

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Dec 7, 2023

πŸ—’οΈ Description

Adds a new command evm_bytes_to_python which takes a single argument that is an hex string and converts it to its python Opcodes representation.

πŸ”— Related Issues

None

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@spencer-tb
Copy link
Collaborator

spencer-tb commented Jan 8, 2024

I've added some basic tests in the above commit: 5a132ea

Very useful, I used this today :)

(we probably wan't to restructure the entry_points folder at somepoint)

@marioevz
Copy link
Member Author

marioevz commented Jan 8, 2024

I've added some basic tests in the above commit: 5a132ea

Very useful, I used this today :)

Changes look great, thanks!

@marioevz marioevz marked this pull request as ready for review January 8, 2024 17:07
@marioevz marioevz added the type:feat type: Feature label Jan 9, 2024
@marioevz marioevz merged commit e07bfbe into ethereum:main Jan 9, 2024
5 checks passed
@marioevz marioevz deleted the evm-bytes-parser branch January 9, 2024 15:49
@danceratopz danceratopz mentioned this pull request Jan 10, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feat type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants