-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Updated fork name from Merge -> Paris #363
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks for helping out with this!
There is still an issue with this change and it's that the transition tool, the tool we call to perform the evm execution of the transactions included in the block, it still expects "Merge" when receiving the fork name for Paris.
It would be a bit messy to try to do this with the rest of the code as is right now, mainly because we don't have the code in place to handle such discrepancy, but I've opened this PR #366 that implements exactly that.
I would:
- Wait until forks: Add fork-specific, non-inherited class variablesΒ #366 is merged
- Rebase your branch on top of main
And then we should be able to merge your contribution :)
Sounds great! I've incorporated the suggested modifications. Thanks a lot for your help. |
Hey @MukulKolpe thanks for the changes!
|
Yes please! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for helping out on this :)
All looks good to me - apart from the folder name:
tests/merge/... -> tests/paris/...
And then the changelog!
dd733a9
to
20301a6
Compare
20301a6
to
12c0cb1
Compare
12c0cb1
to
8be0683
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic! Thank you so much for this!
Thanks @spencer-tb, @marioevz!! |
Thanks! @MukulKolpe |
ποΈ Description
Updated Fork name from "Merge" to "Paris" within the repository.
π Related Issues
Fixes #362
β Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.