Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools(fix): Storage iterator #369

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Jan 3, 2024

🗒️ Description

Storage iterator was broken, so a for loop could not iterate over it (it returned a zero key even if it didn't have the zero key).

Fix was to return the iterator of the data field.

🔗 Related Issues

None

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added the scope:fw Scope: Framework (evm|tools|forks|pytest) label Jan 3, 2024
Copy link
Collaborator

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@marioevz marioevz merged commit f71a615 into ethereum:main Jan 5, 2024
5 checks passed
spencer-tb pushed a commit to spencer-tb/execution-spec-tests that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:fw Scope: Framework (evm|tools|forks|pytest)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants