-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tests): add reentrancy suicide revert test #372
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me :) Just a few comments, which might need a rebase.
It might be worth it to run tox
to highlight any other issues related to linting if any (Just run tox
in the execution-spec-tests
folder with venv enabled).
tests/cancun/eip6780_selfdestruct/test_double_selfdestruct_revert.py
Outdated
Show resolved
Hide resolved
tests/cancun/eip6780_selfdestruct/test_double_selfdestruct_revert.py
Outdated
Show resolved
Hide resolved
tests/cancun/eip6780_selfdestruct/test_double_selfdestruct_revert.py
Outdated
Show resolved
Hide resolved
19ae098
to
14ad8e5
Compare
LGTM! I'm nit-picking but it would be good to follow these 2 additional items that we started a few months ago. They don't need to be perfect but should help us in the future for finding issues or PRs in the future.
|
Can this also be scripted in github CI checks? |
Great idea, for the labels most likely and similarly with the Changelog! Maybe after a PR is created, depending on the labels assigned by the CI, the relavent PR name is given. Can discuss on this weeks call :) |
git commit also should have |
Also CI should try to fill the test and see if it actually fills without errors |
I'd say the ideal scenario is to have a single squashed commit message with the above yeah - purely for improved commit history on main :)
Tox should already be doing this, in the order specified within the tox.ini file |
ποΈ Description
Test requested by chfast about suicide reentrancy and revert.
π Related Issues
Resolves this issue.
β Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.