-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools(feat): Add defined exceptions #384
Conversation
00d767d
to
ed5aa65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! LGTM
I'd actually like this for consume via engine api ASAP :)
These expected errors will make invalid tests work!
ce81273
to
7ccf5e4
Compare
7ccf5e4
to
ae4af05
Compare
Rebased to main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really love this. Very clean! And the docs look great, too. I added a link to an example in the tests for each exception type in /writing_tests/exception_tests/
in 1d8c570.
Co-authored-by: danceratopz <danceratopz@gmail.com>
🗒️ Description
Adds
BlockException
andTransactionException
enums, which supersede the string-based exceptions, in order to provide a set of defined exceptions, which results in better control of the tests that produce exception conditions.🔗 Related Issues
None
✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.