feat(fw): Parameter count check on opcode calls #492
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Adds a simple check that the number of parameters used to call an opcode (to generate bytecode) is the same as the popped stack items for the given opcode.
E.g.
Now results in:
"ValueError: Opcode CREATE requires 3 stack elements, but 7 were provided. Use 'unchecked=True' parameter to ignore this check."
.This works:
The check is superficial as it does not verify that the bytecode specified on each parameter indeed pushes 1 item to the stack.
@winsvega
🔗 Related Issues
#441
✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.