-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(consume): enable loading of ethereum/tests/BlockchainTests
#596
feat(consume): enable loading of ethereum/tests/BlockchainTests
#596
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Amazing that we can run these now :D
My only confusion surrounding this is why Is it 22953 test files maybe? Will have another look |
Good question! @winsvega moved non-Cancun tests to "legacy tests" in the ethereum/tests branch being used here. We should try loading those tests too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This is to save time and to be able to edit existing tests without breaking anything. The main tests are on >=Cancun to ensure that from current point on there will be no async hardforks. Thats why we focus on those. |
Perfect! Yeah this makes a lot of sense. There is no point in maintaining the older fork versions of the tests in my eyes. But still a nice to have!
Agreed! Happy for you to merge this :) |
Co-authored-by: spencer <spencer.taylor-brown@ethereum.org>
🗒️ Description
Enables loading
ethereum/tests/BlockchainTests
(except for 5 json files that define invalid fields via "bigint").post_state
an optional field in blockchain fixtures.genindex
(the fixtures here all currently usebigint
to define invalid fields in json).hasher
to use_info["generatedTestHash"]
as a synonym for_info["hash"]
(this allowsgenindex
to check whether theindex.json
is up-to-date forethereum/tests
; otherwise it must be regenerated every time).This requires: ethereum/tests#1380.
Test loading of fixtures into EEST pydantic models with:
genindex -i ~/path/to/ethereum/tests/BlockchainTests/
Expected output:
The resulting
index.json
file contains 22953 tests.🔗 Related Issues
#572
✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.