-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: simplify python project config #764
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danceratopz
requested review from
spencer-tb and
marioevz
and removed request for
spencer-tb
August 26, 2024 15:49
…ystem" This reverts commit 7e91004.
spencer-tb
reviewed
Aug 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very much in favor of this! :D
marioevz
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a good idea to do this now, and PR looks good to me with a minor comment. Thanks!
Co-authored-by: Mario Vega <marioevz@gmail.com>
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
This PR consolidates the project's config into
pyproject.toml
(and.flake8
-flake8
doesn't supportpyproject.toml
; this config file can be removed later if we replaceflake8
withruff
).This brings EEST more inline with modern Python project standards: "Starting with PEP 621, the Python community selected
pyproject.toml
as a standard way of specifying project metadata.", cf setuptools.pypa.This is a first step so that EEST can:
This PR does some additional clean-up of the config in
pyproject.toml
:setup.py
to discover sub-modules (see 20fa624) but packages to include were additionally manually listed insetup.cfg
. Now, auto-discovery is adequate with the use ofexclude
inpyproject.toml
."py.typed"
as package data; these are added by default in newer versions of setuptools (Include type information by default pypa/setuptools#4021).Testing module/package-data inclusion/exclusion
To check that test modules aren't included but manually specified .bin files and py.typed files are, I tested wheel building using:
🔗 Related Issues
None.
✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.