Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fill): add solc plugin and automatic installation of solc #772

Merged
merged 9 commits into from
Aug 29, 2024

Conversation

danceratopz
Copy link
Member

@danceratopz danceratopz commented Aug 28, 2024

🗒️ Description

  • Adds a new plugin solc (most logic is refactored from fill to this plugin).
  • Adds a new command-line flag --solc-version=x.y.z to fill
  • Adds logic to install the version specified by the flag via solc-select automatically when fill is called.
  • If --solc-bin is specified, solc-select is not used; old behavior remains.

The only difference is that by default (if neither of the solc flags are specified), the first solc in the path is no longer taken; rather the default version of solc as currently specified by the plugin is used via solc-select (0.8.24).

solc-select has proven to be reliable if configured correctly. Unfortunately, the config is lost when switching venv; this avoids this pitfall.

🔗 Related Issues

#604 #618

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@danceratopz danceratopz added type:feat type: Feature scope:fw Scope: Framework (evm|tools|forks|pytest) labels Aug 28, 2024
@danceratopz danceratopz changed the title feat(fill): add solc plugin with automatic installation of solc feat(fill): add solc plugin and automatic installation of solc Aug 28, 2024
As they mess with solc-select's diretory structure in the active venv, don't run them in parallel with xdist, rather run them in a separate pytest session with sequential execution.
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one comment. Thanks!

src/pytest_plugins/filler/tests/test_solc.py Outdated Show resolved Hide resolved
@danceratopz danceratopz merged commit bc820c6 into main Aug 29, 2024
7 checks passed
@danceratopz danceratopz deleted the feat/use-solc-specified-by-flag branch August 29, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:fw Scope: Framework (evm|tools|forks|pytest) type:feat type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants