Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fw): DATALOAD pushed_stack_items #784

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

pdobacz
Copy link
Collaborator

@pdobacz pdobacz commented Sep 4, 2024

🗒️ Description

DATALOAD pushes an item, same as RETURNDATALOAD and CALLDATALOAD, not sure why I missed this when doing the recent DATALOADN fix. I think now the 4 data opcodes are ok

I noticed this after getting deep into the Bytecode.__add__ algorithm for calculating max stack height. I have a case which it seems to be mishandling (no jumps or callfs!), but I have so far been unable to fix the algorithm. If I give up, I'll just post an issue to reproduce the problematic case.

🔗 Related Issues

NA

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@pdobacz pdobacz requested a review from marioevz September 4, 2024 16:34
@marioevz marioevz merged commit 8eed02f into ethereum:main Sep 6, 2024
4 checks passed
@marioevz marioevz deleted the fix-stack-height branch September 6, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants