fix(fw): DATALOAD pushed_stack_items #784
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
DATALOAD pushes an item, same as RETURNDATALOAD and CALLDATALOAD, not sure why I missed this when doing the recent DATALOADN fix. I think now the 4 data opcodes are ok
I noticed this after getting deep into the
Bytecode.__add__
algorithm for calculating max stack height. I have a case which it seems to be mishandling (no jumps or callfs!), but I have so far been unable to fix the algorithm. If I give up, I'll just post an issue to reproduce the problematic case.🔗 Related Issues
NA
✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.