Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): Fix Existing EOF + EIP-7702 Tests #821

Merged
merged 4 commits into from
Sep 19, 2024
Merged

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Sep 19, 2024

🗒️ Description

  • Fixes some issues with EIP-7702 tests when parametrized to EOF variants in PragueEIP7692 fork.
  • Fixes Conditional code generator in EOF mode.

We should be able to release a new EOF tests release after this is merged.

🔗 Related Issues

None

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added scope:tests Scope: Test cases type:chore Type: Chore type:test Type: Test scope:fw Scope: Framework (evm|tools|forks|pytest) labels Sep 19, 2024
@marioevz marioevz changed the title fix(tests): EOF + EIP-7702 Tests fix(tests): Fix Existing EOF + EIP-7702 Tests Sep 19, 2024
Copy link
Collaborator

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

docs/CHANGELOG.md Outdated Show resolved Hide resolved
docs/CHANGELOG.md Outdated Show resolved Hide resolved
@marioevz marioevz merged commit c0a381c into main Sep 19, 2024
7 checks passed
@marioevz marioevz deleted the fix-eof-7702-tests branch September 19, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:fw Scope: Framework (evm|tools|forks|pytest) scope:tests Scope: Test cases type:chore Type: Chore type:test Type: Test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants