-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugins): Create concurrency
pytest plugin
#824
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
danceratopz
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice abstraction. So nice to get this out of the cli and abstracted to this plugin.
LGTM, just a few minor comments, mainly help/docstrings below.
Co-authored-by: danceratopz <danceratopz@gmail.com>
@danceratopz awesome suggestions, thanks for the review, I'll merge in a bit :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Creates a new plugin that facilitates concurrency in all test-related commands such as fill, consume and execute.
Before the plugin, all different plugins created its own temporary folder in order to save information that was meant to be share across different
xdist
processes (e.g. the execution client running the tests in consume, or in execute hive), and it relied on each plugin having the temporary folder being passed by the command caller for all instances to coincide on the same folder name.Now the concurrency plugin uses testrun_uid to generate a deterministic temporary folder that will be the same across processes, and can be used for coordination.
🔗 Related Issues
Functionality initially added in #712.
✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.