-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: block witness checks and test fixes #857
Merged
spencer-tb
merged 86 commits into
ethereum:verkle/main
from
spencer-tb:verkle/block-witness-checks
Oct 1, 2024
Merged
feat: block witness checks and test fixes #857
spencer-tb
merged 86 commits into
ethereum:verkle/main
from
spencer-tb:verkle/block-witness-checks
Oct 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Exhaustive check fixes
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
verkle: add eip-7709 test
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
spencer-tb
added a commit
to spencer-tb/execution-spec-tests
that referenced
this pull request
Oct 1, 2024
* basic witness checks * feat(fw): add verkle chunkify code helper. * feat(fw): add all verkle sub commands. * chore: add chunkify code to init. * chore: remove witness. * chore: remove old witness check. * feat(fw): add witness checks init api. * chore: fix filling tmp. * refactor(fw|evm): use WitnessCheck as temp data struct pre-filling. * chore(fw|evm): fix witness check during fill. * feat(fw): verify witness function. * tests: witness check test_balance. * tests: update witness check test_blockhash_instruction. * tests: update witness check for remaining tests. * chore: rename basic mpt to vkt test as transition. * tests: temp fix test_contract_execution. * chore: fix format witness check function. * feat: add basic data values big-endian encoding. * chore: improve and fix error messages. * chore: more improvements to error messages. * chore: fix code hash for witness check. * chore: more improvements to error messages 2. * chore: more improvements to error messages 3. * chore: temp test fix. * chore: skip blockhash storage slot check temp. * chore: fix eip4762 test calls. * tests: small changes. * verkle: fix test Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * verkle: test fix Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * verkle: fix selfdestruct tests Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * verkle: fix sstore Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * verkle: fix extcodesize test Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * verkle: fix extcodehash tests Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * verkle: contract execution fixes Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * fixes Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * verkle: many contract execution fixes Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * verkle: fix more tests bugs Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * verkle: fix create tests Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * verkle: add create with insufficient balance value-bearing Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * verkle: create with big calldata fixes Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * verkle: fix sload test Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * verkle: uncomment contract execution subtests Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * chore: typing bytes fix. * verkle: more fixes Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * verkle: enable all code execution tests Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * feat: make witness checks exhaustive. * fix: bug in code chunk. * feat: test_balance exhaustive checks example. * temp-fix: check hist. storage cont. * compilation fixes Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * more fixes Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * verkle: fixes Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * verkle: call warm fixes Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * verkle: fixes Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * fixes Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * simplify Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * verkle: fixes Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * verkle: codecopy/extcodecopy fixes Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * verkle: remove noisy comments Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * verkle: fix coinbase assertions Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * verkle: fixes Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * verkle: fix creates tests Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * verkle: fixes Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * verkle: extcodesize fixes Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * verkle: selfdestruct fixes Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * verkle: fix sload Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * verkle: sstore fixes Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * verkle: fix transfer Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * verkle: more calls fixes Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * verkle: more fixes Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * verkle: more fixes Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * verkle: more fixes Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * disable temporarily 7709 tests Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * verkle: reenable sub-test * verkle: enable sub-tests with partial witness charging * verkle: reenable call subtests Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * verkle: add eip-7709 test Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * verkle: 7709 fixes Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * verkle: update 7709 blockhash values Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * fixes Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * fixes Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * fixes Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * verkle: add codecopy test with size bigger than contract Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * verkle: add system contract execution test via CALL Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> --------- Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> Co-authored-by: Ignacio Hagopian <jsign.uy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Adds verkle block witness checks and test fixes.