refactor(ethereum_clis): move generic code from TransitionTool
to a new generic base class EthereumCLI
#894
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
This refactors
src/evm_transition_tool/
to a more librarysrc/ethereum_clis/
. The main aim being to allow easier definition of EVM sub-commands (for use in consume, for example) that can take advantage of a new base classEthereumCLI
.Next Steps
I would prefer to keep this PR tight in scope, in subsequent PRs, the next steps would be to:
TransitionTool
and to subclass them from newStateTest
andBlockTest
classes (which in turn are derived from theEthereumCLI
base class.Solc
class fromsrc/ethereum_test_tools/code/yul.py
tosrc/ethereum_clis/
.statetest
andblocktest
commands for other clients and use them in consume direct.🔗 Related Issues
None.
✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.