Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(tests): EIP-7702: Add many-delegations test #923

Merged
merged 4 commits into from
Oct 31, 2024
Merged

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Oct 29, 2024

🗒️ Description

Add test where a single transaction includes as many delegations as the max block gas allows:

  • With or without balance in the auth signer accounts (empty vs non-empty account in state)
  • With 20 million gas (to execute test on live networks) or 120 million gas

🔗 Related Issues

None

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added the scope:tests Scope: Test cases label Oct 29, 2024
Copy link
Collaborator

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marioevz marioevz merged commit 83de6e1 into main Oct 31, 2024
5 checks passed
@marioevz marioevz deleted the 7702-perf-test branch October 31, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:tests Scope: Test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants