JSON-RPC: Add eth_createAccessList RPC call
#196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lightclient @alita-moore can you have a quick look before I merge? TY! |
alita-moore
approved these changes
May 26, 2021
lightclient
reviewed
May 26, 2021
| "gasUsed": { | ||
| "$ref": "#/components/schemas/Integer" | ||
| }, | ||
| "vmErr": { |
There was a problem hiding this comment.
Is this field optional? If an error is returned, is accessList and gasUsed omitted?
|
oooooof |
|
@timbeiko don't push the button so early 🙈 I wanted to have some discussions on it first |
|
Oops, sorry! Will revert this. |
|
@MariusVanDerWijden reverted in faac97e. Can you open a new PR with the same changes and I'll make sure to leave it open until you tell me to merge :-) ? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.