Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize Eth1-specs Repo & Add Network Upgrades Info #24

Merged
merged 2 commits into from
Apr 9, 2021
Merged

Conversation

timbeiko
Copy link
Collaborator

@timbeiko timbeiko commented Apr 8, 2021

Two big changes in this PR (I know...):

  1. Change the top-level README & folder structure to make it clear that more than network upgrades spec are tracked here (specifically, the JSON RPC spec);
  2. Clarify the CFI process by including some information from a previously opened PR.

Given that ethereum/pm#295 and #23 are still opened, I did not clarify where CFI is being tracked, or whether it resets every upgrade. Based on the outcome of these two issues, more changes will be necessary, but I think merging this is a net improvement.

Signed-off-by: Tim Beiko <t.beiko23@gmail.com>
@timbeiko
Copy link
Collaborator Author

timbeiko commented Apr 8, 2021

cc: @holgerd77

Copy link
Collaborator

@poojaranjan poojaranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested minor edits. Wondering if the upgrade process flow can be added for a quick visual of the phases and EIP status instructions.

README.md Show resolved Hide resolved
network-upgrades/README.md Outdated Show resolved Hide resolved
network-upgrades/README.md Outdated Show resolved Hide resolved
network-upgrades/README.md Outdated Show resolved Hide resolved
network-upgrades/README.md Outdated Show resolved Hide resolved
network-upgrades/README.md Show resolved Hide resolved
Signed-off-by: Tim Beiko <t.beiko23@gmail.com>
@timbeiko
Copy link
Collaborator Author

timbeiko commented Apr 8, 2021

@poojaranjan thanks for the quick review! Addressed the bulk of your comments in the last commit. Still two open threads to discuss.

Re: the diagram, if we have an updated one, yes, we should add it We can also add it in a subsequent PR if we don't have one now.

@poojaranjan
Copy link
Collaborator

@timbeiko
I'm fine with making the edits later on. Comments resolved.

Diagram: I have got the updated diagram here. One major change from the earlier version, CFI approved is moved to CFI phase. Looks like it was mistakenly shown in the Devnet phase. If you'd rather like to have only one CFI instead of applied and approved, I can make the edits, let me know.

image

@timbeiko timbeiko merged commit 01fb7ab into master Apr 9, 2021
@timbeiko
Copy link
Collaborator Author

timbeiko commented Apr 9, 2021

Thanks @poojaranjan just added the diagram in a separate commit 😄 !

lightclient pushed a commit to lightclient/execution-specs that referenced this pull request Jun 30, 2021
@SamWilsn SamWilsn deleted the refactor branch April 10, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants