Make clippy satisfy

ethereum · Dec 12, 2022 · 872f565 · 872f565
1 parent f594b6b
commit 872f565
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 8 deletions.
diff --git a/crates/codegen/src/cgu.rs b/crates/codegen/src/cgu.rs
@@ -12,7 +12,7 @@ use indexmap::IndexMap;
 
 use crate::db::CodegenDb;
 
-#[derive(Debug, Clone, PartialEq, Eq)]
+#[derive(Debug, Clone, Eq)]
 pub struct CodegenUnit {
     pub module: ModuleId,
 
@@ -33,6 +33,14 @@ impl CodegenUnit {
     }
 }
 
+impl PartialEq for CodegenUnit {
+    fn eq(&self, other: &Self) -> bool {
+        self.module == other.module
+            && self.contracts == other.contracts
+            && self.functions == other.functions
+    }
+}
+
 impl Hash for CodegenUnit {
     fn hash<H: Hasher>(&self, state: &mut H) {
         self.module.hash(state);

diff --git a/crates/codegen/src/db/queries/cgu.rs b/crates/codegen/src/db/queries/cgu.rs
@@ -180,10 +180,7 @@ impl<'db> CguFunctionBuilder<'db> {
             .iter()
             .map(|param| {
                 let ty = match &param.ty.data(self.db.upcast()).kind {
-                    TypeKind::TypeParam(def) => {
-                        let ty = substs[&def.name];
-                        ty
-                    }
+                    TypeKind::TypeParam(def) => substs[&def.name],
                     _ => param.ty,
                 };
 

diff --git a/crates/codegen/src/yul/dependency_graph.rs b/crates/codegen/src/yul/dependency_graph.rs
@@ -110,13 +110,13 @@ impl DependencyGraph {
                         ..
                     } => {
                         self.update_graph_by_func(db, cgus, *callee);
-                        let callee_node = self.func_node_map[&callee];
+                        let callee_node = self.func_node_map[callee];
                         self.dep_graph.update_edge(func_node, callee_node, ());
                     }
 
                     InstKind::Create { contract, .. } | InstKind::Create2 { contract, .. } => {
                         self.update_graph_by_contract(db, cgus, *contract);
-                        let contract_node = self.contract_node_map[&contract];
+                        let contract_node = self.contract_node_map[contract];
                         self.dep_graph
                             .update_edge(self.contract_scope.unwrap(), contract_node, ());
                         self.dep_graph.update_edge(func_node, contract_node, ());

diff --git a/crates/codegen/src/yul/isel/function.rs b/crates/codegen/src/yul/isel/function.rs
@@ -46,7 +46,7 @@ pub(crate) fn lower_function(
     let sig_data = &db.codegen_legalized_signature(func.sig);
     let body = &mut func.body;
     legalize_func_body(db, body);
-    FuncLowerHelper::new(db, ctx, func.sig, sig_data, &body).lower_func()
+    FuncLowerHelper::new(db, ctx, func.sig, sig_data, body).lower_func()
 }
 
 struct FuncLowerHelper<'db, 'a> {