Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String literals #186

Closed
g-r-a-n-t opened this issue Jan 15, 2021 · 0 comments
Closed

String literals #186

g-r-a-n-t opened this issue Jan 15, 2021 · 0 comments
Labels
comp: compiler prio: P2 required type: feature
Milestone
Uniswap Demo

Comments

@g-r-a-n-t
Copy link
Member

What is wrong?

We do not support string literal expressions (i.e. "the quick brown fox...").

How can it be fixed

Store these strings within the contract bytecode and load them when referenced.
@g-r-a-n-t g-r-a-n-t added this to the Uniswap Demo milestone Jan 15, 2021
cburgdorf added a commit to cburgdorf/fe that referenced this issue Jan 20, 2021
@cburgdorf
Add support for string literals
376ca21 
Closes ethereum#186
cburgdorf added a commit to cburgdorf/fe that referenced this issue Jan 20, 2021
@cburgdorf
Add support for string literals
74a5a83 
Closes ethereum#186
cburgdorf added a commit to cburgdorf/fe that referenced this issue Jan 20, 2021
@cburgdorf
Add support for string literals
318519b 
Closes ethereum#186
cburgdorf added a commit to cburgdorf/fe that referenced this issue Jan 20, 2021
@cburgdorf
Add support for string literals
c738036 
Closes ethereum#186
cburgdorf added a commit to cburgdorf/fe that referenced this issue Jan 20, 2021
@cburgdorf
Add support for string literals
a257be8 
Closes ethereum#186
@cburgdorf cburgdorf mentioned this issue Jan 20, 2021
Merged
3 tasks
cburgdorf added a commit to cburgdorf/fe that referenced this issue Jan 21, 2021
@cburgdorf
Add support for string literals
d166bf4 
Closes ethereum#186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: compiler prio: P2 required type: feature
Projects
None yet
Milestone
Uniswap Demo
Development

No branches or pull requests
1 participant
@g-r-a-n-t