Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full support for pub qualifier on structs #236

Closed
cburgdorf opened this issue Feb 5, 2021 · 0 comments
Closed

Full support for pub qualifier on structs #236

cburgdorf opened this issue Feb 5, 2021 · 0 comments
Labels
comp: analyzer Everything that involves the analyzer pass comp: compiler type: feature

Comments

@cburgdorf
Copy link
Collaborator

What is wrong?

When #203 lands, we'll have basic support for structs.

struct House:
    price: u256
    size: u256
    pub vacant: bool

Notice that vacant uses pub to declare that the field is public. We know that we want to allow pub qualifier which will become most relevant for when structs are allowed to have methods. This is why the parser does already recognize it. However, it doesn't have any effect yet.

How can it be fixed

  1. Define how visibility of struct fields should work exactly
  2. Make the relevant changes to analyzer and mapper pass
@cburgdorf cburgdorf added comp: compiler type: feature comp: analyzer Everything that involves the analyzer pass labels Feb 5, 2021
@cburgdorf cburgdorf mentioned this issue Feb 5, 2021
6 tasks
cburgdorf added a commit to cburgdorf/fe that referenced this issue Jan 4, 2022
cburgdorf added a commit to cburgdorf/fe that referenced this issue Jan 4, 2022
cburgdorf added a commit to cburgdorf/fe that referenced this issue Jan 4, 2022
cburgdorf added a commit to cburgdorf/fe that referenced this issue Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: analyzer Everything that involves the analyzer pass comp: compiler type: feature
Projects
None yet
Development

No branches or pull requests

1 participant