Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert messages in assert statements #288

Closed
g-r-a-n-t opened this issue Mar 3, 2021 · 0 comments
Closed

Revert messages in assert statements #288

g-r-a-n-t opened this issue Mar 3, 2021 · 0 comments
Labels
flag: beta-required Required for first beta release
Milestone
Uniswap Demo

Comments

@g-r-a-n-t
Copy link
Member

What is wrong?

String literals in assert statements are currently ignored.

For example, the string literal "my revert message" in the following statement has no effect.

assert a == b, "my revert statement"

How can it be fixed

The revert message should be loaded into memory and returned.
@g-r-a-n-t g-r-a-n-t added this to the Uniswap Demo milestone Mar 3, 2021
@cburgdorf cburgdorf added the flag: beta-required Required for first beta release label Mar 24, 2021
cburgdorf added a commit to cburgdorf/fe that referenced this issue Apr 20, 2021
@cburgdorf
Add support for revert reason strings in assert statement
290a857 
Closes ethereum#288
cburgdorf added a commit to cburgdorf/fe that referenced this issue Apr 20, 2021
@cburgdorf
Add support for revert reason strings in assert statement
f2b37f1 
Closes ethereum#288
cburgdorf added a commit to cburgdorf/fe that referenced this issue Apr 20, 2021
@cburgdorf
Add support for revert reason strings in assert statement
4e27a29 
Closes ethereum#288
@cburgdorf cburgdorf mentioned this issue Apr 20, 2021
Merged
cburgdorf added a commit to cburgdorf/fe that referenced this issue Apr 21, 2021
@cburgdorf
Add support for revert reason strings in assert statement
cf736bf 
Closes ethereum#288
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flag: beta-required Required for first beta release
Projects
None yet
Milestone
Uniswap Demo
Development

No branches or pull requests
2 participants
@cburgdorf @g-r-a-n-t