Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert remaining old-style analyzer errors to new style error messages #432

Closed
cburgdorf opened this issue Jun 1, 2021 · 0 comments
Closed

Convert remaining old-style analyzer errors to new style error messages #432

cburgdorf opened this issue Jun 1, 2021 · 0 comments
Labels
comp: analyzer Everything that involves the analyzer pass type: feature type: ui/ux
Milestone
June Release: 0.6...

Comments

@cburgdorf
Copy link
Collaborator

What is wrong?

With https://github.com/ethereum/fe/pull/398/files the analyzer was taught how to produce context-rich error messages in the same style that the parser produces them (using context.fancy_error(...). The PR changes a lot but not all of them.

How can it be fixed

Continue porting them over.
@cburgdorf cburgdorf added type: ui/ux comp: analyzer Everything that involves the analyzer pass labels Jun 1, 2021
@cburgdorf cburgdorf mentioned this issue Jun 7, 2021
Merged
cburgdorf added a commit to cburgdorf/fe that referenced this issue Jun 9, 2021
@cburgdorf
Migrate remaining errors
358dfdc 
Closes ethereum#432
cburgdorf added a commit to cburgdorf/fe that referenced this issue Jun 9, 2021
@cburgdorf
Migrate remaining errors
d6c4240 
Closes ethereum#432
@cburgdorf cburgdorf mentioned this issue Jun 9, 2021
Merged
cburgdorf added a commit to cburgdorf/fe that referenced this issue Jun 9, 2021
@cburgdorf
Migrate remaining errors
7193b1a 
Closes ethereum#432
@sbillig sbillig closed this as completed in 464cd3c Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: analyzer Everything that involves the analyzer pass type: feature type: ui/ux
Projects
None yet
Milestone
June Release: 0.6.0-alpha Feldspar
Development

No branches or pull requests
1 participant
@cburgdorf