Ensure that the compiler only panics for legitimate bugs #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #437 +/- ##
==========================================
- Coverage 86.22% 86.10% -0.13%
==========================================
Files 72 72
Lines 4785 4792 +7
==========================================
Hits 4126 4126
- Misses 659 666 +7
Continue to review full report at Codecov.
|
g-r-a-n-t
commented
Jun 2, 2021
g-r-a-n-t
commented
Jun 2, 2021
g-r-a-n-t
commented
Jun 2, 2021
g-r-a-n-t
force-pushed
the
all-panics-bugs
branch
4 times, most recently
from
d8b9feb
to
aad4c4b
Compare
sbillig
approved these changes
Jun 3, 2021
| } | ||
| fe::ModuleStmt::SimpleImport { .. } => { | ||
| context.not_yet_implemented("simple import", stmt.span) | ||
| } |
There was a problem hiding this comment.
We could probably cut these from the ast too (though I have no strong feelings about it)
There was a problem hiding this comment.
Decided I'd leave it in there, since we may still use this syntax for imports.
satyamakgec
approved these changes
Jun 3, 2021
g-r-a-n-t
force-pushed
the
all-panics-bugs
branch
from
aad4c4b
to
e831d33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
closes #436
How was it fixed?
Refactored front-end "not implemented" errors into analyzer errors and removed questionable variants.
To-Do
OPTIONAL: Update Spec if applicable
Add entry to the release notes (may forgo for trivial changes)
Clean up commit history