Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for development in both Docker and Github Codespace. #1000

Merged
merged 1 commit into from May 4, 2024
Merged

Add support for development in both Docker and Github Codespace. #1000

merged 1 commit into from May 4, 2024

Conversation

ghost
Copy link

@ghost ghost commented May 2, 2024

What was wrong?

There is no support for Devcontainer

How was it fixed?

Added .devcontainer/devcontainer.json file.

To-Do

  • OPTIONAL: Update Spec if applicable

  • Add entry to the release notes (may forgo for trivial changes)

  • Clean up commit history

Copy link
Collaborator

@sbillig sbillig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afsec Thanks! I haven't used gh codespaces (until testing this), but it seems useful to have this defined. Maybe I'll start reviewing PRs in codespaces and further tie myself to gh 🕺. I have a slight feeling that we should keep the set of installed extensions and customizations as minimal as possible, but I just tried this and decided that it seems fine for now. Someone can modify and submit another PR if they feel strongly about it.

Someday when the compiler is ready to be used by people for real things, maybe we'll want to be more careful about such things. Minimizing the attack surface is prudent, even though it's unlikely that someone compromises a popular vscode extension in order to inject some code into the fe compiler to change people's contracts to steal funds or whatever.

(Ignoring the CI failures; they're all unrelated and have been fixed elsewhere)

@sbillig sbillig merged commit 52c864c into ethereum:fe-v2 May 4, 2024
2 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant