Update revm #1003
Merged
Update revm #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-r-a-n-t
force-pushed
the
update-revm
branch
2 times, most recently
from
7109bed
to
1f9edac
Compare
g-r-a-n-t
commented
May 3, 2024
| // #[cfg(not(target_arch = "wasm32"))] | ||
| // test_ingot! { dep_unavailable_rev } | ||
| // #[cfg(not(target_arch = "wasm32"))] | ||
| // test_ingot! { dep_unavailable_source } |
There was a problem hiding this comment.
it looks like the git2 crate we're using for dep resolution isn't returning errors for non-existent repositories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The test runner crate was using version 3 of revm, which caused CI issues.
How was it fixed?
Switched to the latest version of revm and made the test-runner compatible.
To-Do