Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add usize and isize primitive types #1012

Merged
merged 3 commits into from
Jun 10, 2024
Merged

add usize and isize primitive types #1012

merged 3 commits into from
Jun 10, 2024

Conversation

lana-shanghai
Copy link

What was done?

Added usize and isize types. Solves #995

@lana-shanghai
Copy link
Author

Hey @Y-Nak lmk if it looks good?

Y-Nak
Y-Nak reviewed Jun 9, 2024
View reviewed changes
Copy link
Member

@Y-Nak Y-Nak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delayed review.
LGTM overall. I left some minor nits.
I'll merge this PR when these nits are addressed.
Thanks!

crates/hir-analysis/src/ty/ty_def.rs Outdated Show resolved Hide resolved
crates/hir-analysis/src/ty/ty_def.rs Outdated Show resolved Hide resolved
crates/hir/src/hir_def/prim_ty.rs Outdated Show resolved Hide resolved
crates/hir/src/hir_def/prim_ty.rs Outdated Show resolved Hide resolved
Y-Nak
Y-Nak reviewed Jun 10, 2024
View reviewed changes
Copy link
Member

@Y-Nak Y-Nak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The keywords defined by the define_keywords macro are const values.
So it'd be better to keep the upper case names. Other fixes are great!

crates/hir/src/hir_def/ident.rs Outdated Show resolved Hide resolved
crates/hir/src/hir_def/ident.rs Outdated Show resolved Hide resolved
@lana-shanghai
Copy link
Author

@Y-Nak got it, left the keywords in capitals

@Y-Nak
Copy link
Member

Y-Nak commented Jun 10, 2024

Thank you!
(The CI failure is not related to this PR. Please ignore it; I'll fix it later(It's just a broken link in a book)).

@Y-Nak Y-Nak merged commit 5f36438 into ethereum:fe-v2 Jun 10, 2024
6 of 7 checks passed
@Y-Nak Y-Nak mentioned this pull request Jun 10, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Y-Nak Y-Nak Y-Nak left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lana-shanghai @Y-Nak