-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update salsa #1015
Merged
Merged
Update salsa #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Y-Nak
force-pushed
the
update-salsa
branch
2 times, most recently
from
June 27, 2024 12:32
58e5a22
to
59b3a79
Compare
sbillig
approved these changes
Jul 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
That's a whole lotta lifetime annotations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates salsa to salsa 3.0. The major changes are
'db
lifetime.macros. I just removed the
fe-macro` crate.salsa::update::Update
trait to store a type in another tracked type. In normal cases, we can usesalsa::Update
derive macro. The only types that I implemented the trait manually arePartial
andIndexSet/IndexMap
.Please refer to salsa-rs/salsa#490 for more details.
@micahscopes I decided to leave the lsp crate as is, so it can't be compiled right now. Also, I temporarily excluded the language server crate from the workspace in dce1e09 to build/test the compiler itself. If you have any trouble migrating to salsa 3.0, please let me know.
@g-r-a-n-t This change would affect your driver implementation as well. So please take a quick look at the new driver implementation in this PR.