Add get_type_defs/get_module_type_defs to scope #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cburgdorf
force-pushed
the
christoph/refactoring/scope_type_defs
branch
2 times, most recently
from
ff2305e
to
002fa85
Compare
cburgdorf
force-pushed
the
christoph/refactoring/scope_type_defs
branch
from
002fa85
to
e6a5d4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Nothing wrong but a fall out from #203. This adds convenience helper to the contract and module scopes to filter for a list of type defintions.
How was it fixed?
Basically took some existing code and put it in a function + wrangling 20 minutes about the right syntax for the closure.