Fix bug where compilation of contracts without public functions would result in malformed YUL #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-r-a-n-t
approved these changes
Feb 15, 2021
g-r-a-n-t
reviewed
Feb 15, 2021
output/Empty/Empty_ir.yul
Outdated
| @@ -0,0 +1,168 @@ | |||
| object \"Empty\" { | |||
cburgdorf
force-pushed
the
christoph/fix/empty_contract
branch
from
0ed8cfc
to
f840fff
Compare
Codecov Report
@@ Coverage Diff @@
## master #248 +/- ##
=======================================
Coverage 93.91% 93.91%
=======================================
Files 54 54
Lines 3744 3746 +2
=======================================
+ Hits 3516 3518 +2
Misses 228 228
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
As identified by the fuzzer in #219 contracts without any public functions compile to faulty YUL.
How was it fixed?
Compile to
pop(0)instead ofswitch (..)when there are no public functions.To-Do