Properly reject octal number literals #330
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Currently, the analyzer doesn't consider number literals that start with
0
. This leads to ICE in theyul
mapping pass.fixes #222
How was it fixed?
Reject a number literal if it starts with
0
and has more than two digits.To-Do
Related problem
I also found that lexer doesn't tokenize correctly if number literals start with
0
followed by non zero value.For example,
02
is tokenized intoI'll open an issue for this and address it in another PR.
EDIT: opened #331.