Allow hex/octal/binary radix numeric literals #410
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
closes #333
How was it fixed?
common::numeric::Literal
to abstract string represented numeric literals.BigInt
for semantic analysis, this approach is the same asrustc
does (it holdsu128
for numeric integers).lexical_core
because it doesn't providefrom_str_radix
like methods. And also, I think we don't need to check the details ofIntErrorKind
in almost all cases. This is because, looking at the definition ofIntErrorKind
in detail,IntErrorKind::Empty
is the only error kind that we have to consider it an internal compiler error.To-Do
We may need to reconsider the usage of
BigInt
, I think it would be better to useU256
because: