Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow generic arguments in Expr::Call #425

Merged
merged 1 commit into from
May 27, 2021
Merged

Conversation

Y-Nak
Copy link
Member

@Y-Nak Y-Nak commented May 27, 2021

What was wrong?

fixes #379

How was it fixed?

  1. Add BTParser which thinly wraps Parser and enables backtracking
  2. Add generic_args to ast::Expr::Call
  3. Add if_chain for improving readability

To-Do

  • OPTIONAL: Update Spec if applicable

  • Add entry to the release notes (may forgo for trivial changes)

  • Clean up commit history

@Y-Nak Y-Nak force-pushed the generic-args branch 2 times, most recently from c1111ce to 7bf0403 Compare May 27, 2021 13:16
@Y-Nak Y-Nak changed the title Allow generics in Expr::Call Allow generic arguments in Expr::Call May 27, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2021

Codecov Report

Merging #425 (f308afb) into master (d015b46) will increase coverage by 0.31%.
The diff coverage is 95.58%.

❗ Current head f308afb differs from pull request most recent head 7bf0403. Consider uploading reports for the commit 7bf0403 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #425      +/-   ##
==========================================
+ Coverage   86.32%   86.64%   +0.31%     
==========================================
  Files          68       68              
  Lines        4109     4147      +38     
==========================================
+ Hits         3547     3593      +46     
+ Misses        562      554       -8     
Impacted Files Coverage Δ
compiler/src/yul/mappers/expressions.rs 88.67% <ø> (ø)
parser/src/lexer.rs 86.20% <ø> (ø)
parser/src/lexer/token.rs 21.97% <ø> (ø)
analyzer/src/namespace/types.rs 85.31% <85.71%> (-0.09%) ⬇️
parser/src/parser.rs 74.07% <90.47%> (+1.55%) ⬆️
analyzer/src/traversal/expressions.rs 92.85% <100.00%> (+0.05%) ⬆️
compiler/src/lowering/mappers/expressions.rs 100.00% <100.00%> (ø)
parser/src/grammar/expressions.rs 88.97% <100.00%> (+0.64%) ⬆️
parser/src/grammar/types.rs 82.19% <100.00%> (+5.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d015b46...7bf0403. Read the comment docs.

Copy link
Collaborator

@sbillig sbillig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Y-Nak This looks really great. The BtParser idea is very elegant.

@g-r-a-n-t g-r-a-n-t merged commit 1760025 into ethereum:master May 27, 2021
@Y-Nak Y-Nak deleted the generic-args branch May 28, 2021 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace stringN type names with String<N>
4 participants