Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/let var decl #509

Merged
merged 7 commits into from
Aug 11, 2021
Merged

Feat/let var decl #509

merged 7 commits into from
Aug 11, 2021

Conversation

WilfredTA
Copy link
Contributor

What was wrong?

Described in this issue: #501

Briefly, there is no explicit syntactic distinction between variable declarations and reassignments.

How was it fixed?

Added the requirement that variable declarations are preceded by let keyword, e.g., let x: u8 = 1. Updated all fixtures and demo contracts to be compatible with this change.

To do

Update documentation & website examples to reflect this change.

Copy link
Collaborator

@sbillig sbillig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Added a couple nitpicky comments.

crates/parser/src/grammar/functions.rs Outdated Show resolved Hide resolved
crates/parser/src/grammar/functions.rs Outdated Show resolved Hide resolved
@sbillig sbillig merged commit 0b5eb71 into ethereum:master Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants