Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower revert argument #619

Merged
merged 1 commit into from
Jan 3, 2022
Merged

Lower revert argument #619

merged 1 commit into from
Jan 3, 2022

Conversation

sbillig
Copy link
Collaborator

@sbillig sbillig commented Jan 2, 2022

What was wrong?

The revert arg expr wasn't being lowered, leading to a panic for certain code (eg code that uses a const)

How was it fixed?

🪄

To-Do

  • OPTIONAL: Update Spec if applicable

  • Add entry to the release notes (may forgo for trivial changes)

  • Clean up commit history

@sbillig sbillig force-pushed the lower-revert-arg branch 2 times, most recently from d18b0f1 to 0169d80 Compare January 3, 2022 07:10
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2022

Codecov Report

Merging #619 (d18b0f1) into master (17950f2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head d18b0f1 differs from pull request most recent head 0169d80. Consider uploading reports for the commit 0169d80 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #619   +/-   ##
=======================================
  Coverage   86.51%   86.52%           
=======================================
  Files          96       96           
  Lines        8419     8420    +1     
=======================================
+ Hits         7284     7285    +1     
  Misses       1135     1135           
Impacted Files Coverage Δ
crates/lowering/src/mappers/functions.rs 99.39% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17950f2...0169d80. Read the comment docs.

@sbillig sbillig requested a review from WilfredTA January 3, 2022 08:28
@sbillig sbillig merged commit 43c2ea1 into ethereum:master Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants