-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support events outside of contracts #654
Conversation
Codecov Report
@@ Coverage Diff @@
## master #654 +/- ##
==========================================
+ Coverage 85.81% 85.88% +0.06%
==========================================
Files 97 98 +1
Lines 9075 9081 +6
==========================================
+ Hits 7788 7799 +11
+ Misses 1287 1282 -5
Continue to review full report at Codecov.
|
23d59a4
to
b65e3a4
Compare
b65e3a4
to
f959632
Compare
Thanks, @Maltby! And sorry for the late reply that causes some conflicts. nit;
|
Sorry @Maltby, I should have merged this before I greedily merged my own changes that touch all sorts of analyzer code. |
f959632
to
ed504fa
Compare
ed504fa
to
95430c4
Compare
Thanks, @Maltby! Beautiful work! |
What was wrong?
Events can only be defined within contracts.
closes #80
How was it fixed?
Handle module level events in analyzer and lowering crates.
To-Do