Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require arguments to function calls to be labeled #666

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

sbillig
Copy link
Collaborator

@sbillig sbillig commented Feb 14, 2022

Closes #397

pub fn transfer(self, to: address, _ x: u256):
  self.do_transfer(from: msg.sender, to, x + 1)

fn do_transfer(self, from: address, to: address, _ val: u256):
  pass

To-Do

  • OPTIONAL: Update Spec if applicable

  • Add entry to the release notes (may forgo for trivial changes)

  • Clean up commit history

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2022

Codecov Report

Merging #666 (e7fd51b) into master (edba011) will decrease coverage by 0.10%.
The diff coverage is 81.03%.

@@            Coverage Diff             @@
##           master     #666      +/-   ##
==========================================
- Coverage   82.12%   82.02%   -0.11%     
==========================================
  Files         125      125              
  Lines       10849    10865      +16     
==========================================
+ Hits         8910     8912       +2     
- Misses       1939     1953      +14     
Impacted Files Coverage Δ
crates/analyzer/src/traversal/functions.rs 96.00% <ø> (-0.03%) ⬇️
crates/abi/src/builder.rs 93.05% <33.33%> (-2.60%) ⬇️
crates/analyzer/src/db/queries/functions.rs 90.37% <64.00%> (-3.88%) ⬇️
crates/analyzer/src/namespace/types.rs 72.65% <100.00%> (+0.61%) ⬆️
crates/analyzer/src/traversal/call_args.rs 95.65% <100.00%> (+0.98%) ⬆️
crates/analyzer/src/traversal/expressions.rs 80.76% <100.00%> (-0.19%) ⬇️
crates/lowering/src/mappers/functions.rs 99.41% <100.00%> (+<0.01%) ⬆️
crates/lowering/src/mappers/module.rs 85.36% <100.00%> (+0.18%) ⬆️
crates/parser/src/ast.rs 88.53% <100.00%> (+0.06%) ⬆️
crates/parser/src/grammar/functions.rs 90.52% <100.00%> (+0.12%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edba011...e7fd51b. Read the comment docs.

@sbillig sbillig force-pushed the arg-labels branch 2 times, most recently from 5965049 to 79f2534 Compare March 8, 2022 00:53
@sbillig sbillig marked this pull request as ready for review March 8, 2022 00:55
@sbillig sbillig force-pushed the arg-labels branch 2 times, most recently from fa114c2 to ff5b5ee Compare March 8, 2022 01:16
@sbillig sbillig requested review from Y-Nak and g-r-a-n-t March 8, 2022 01:21
@g-r-a-n-t
Copy link
Member

👿

Copy link
Member

@g-r-a-n-t g-r-a-n-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/o to the man downstairs

Copy link
Member

@Y-Nak Y-Nak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sbillig sbillig merged commit d5c43d5 into ethereum:master Mar 28, 2022
@sbillig sbillig deleted the arg-labels branch March 28, 2022 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Named arguments
4 participants